Skip to content

Conversation

petrochenkov
Copy link
Contributor

It produces annoying warnings on x.py runs.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2019
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=always

Not sure how it managed to sneak in...

@bors
Copy link
Collaborator

bors commented Nov 24, 2019

📌 Commit 2e41ce9 has been approved by Mark-Simulacrum

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Nov 24, 2019

@alexcrichton @Mark-Simulacrum
This is a consequence of the tool checking regression (#64523, #64316 (comment)).
Could someone fix it? We cannot rely on people not pushing code with warnings.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2019
@Mark-Simulacrum
Copy link
Member

How is tidy not #![deny(warnings)] right now though?

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 25, 2019
…acrum

tidy: Remove unused import

It produces annoying warnings on `x.py` runs.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 25, 2019
…acrum

tidy: Remove unused import

It produces annoying warnings on `x.py` runs.
bors added a commit that referenced this pull request Nov 25, 2019
Rollup of 7 pull requests

Successful merges:

 - #65613 (Preserve whitespace inside one-backtick codeblocks)
 - #66512 (Add unix::process::CommandExt::arg0)
 - #66569 (GitHub Actions: preparations, part 1)
 - #66678 (Remove useless line for error index generation)
 - #66684 (Drive-by cleanup in region naming)
 - #66694 (Add some comments to panic runtime)
 - #66698 (tidy: Remove unused import)

Failed merges:

r? @ghost
@bors bors merged commit 2e41ce9 into rust-lang:master Nov 25, 2019
@petrochenkov petrochenkov deleted the tidywarn branch February 22, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants